Skip to content

Conversation

@mpeddada1
Copy link
Contributor

@mpeddada1 mpeddada1 commented Oct 24, 2023

Notes on class initialization:

  • Removing --initialize-at-build-time=com.google.api.client.util.SecurityUtilsTest results in a build time failure:
Error: java.util.concurrent.ExecutionException: com.oracle.graal.pointsto.constraints.UnsupportedFeatureException: No instances of com.google.api.client.util.SecurityUtilsTest are allowed in the image heap as this class should be initialized at image runtime. To see how this object got instantiated use --trace-object-instantiation=com.google.api.client.util.SecurityUtilsTest.
Error: Use -H:+ReportExceptionStackTraces to print stacktrace of underlying exception

To run tests with native image compilation: mvn test -Pnative -Pnative-deps.

Please Note
This PR doesn't include native image support for google-http-java-client-appengine yet which is still running into:

java.lang.Exception: No tests found matching Unique ID [engine:junit-vintage]/[runner:com.google.api.client.extensions.appengine.datastore.AppEngineDataStoreFactoryTest]/[test:testSet(com.google.api.client.extensions.appengine.datastore.AppEngineDataStoreFactoryTest)] OR Unique ID [engine:junit-vintage]/[runner:com.google.api.client.extensions.appengine.datastore.AppEngineDataStoreFactoryTest]/[test:testClear(com.google.api.client.extensions.appengine.datastore.AppEngineDataStoreFactoryTest)] OR Unique ID [engine:junit-vintage]/[runner:com.google.api.client.extensions.appengine.datastore.AppEngineDataStoreFactoryTest]/[test:testLarge(com.google.api.client.extensions.appengine.datastore.AppEngineDataStoreFactoryTest)]

@product-auto-label product-auto-label bot added the size: l Pull request size is large. label Oct 24, 2023
@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. and removed size: l Pull request size is large. labels Nov 6, 2023
@generated-files-bot
Copy link

Warning: This pull request is touching the following templated files:

  • .kokoro/build.sh

@mpeddada1 mpeddada1 changed the title fix: native image configs for google-http-java-client [WIP] fix: native image configs for google-http-java-client Nov 6, 2023
@mpeddada1 mpeddada1 marked this pull request as ready for review November 6, 2023 15:01
@mpeddada1 mpeddada1 requested a review from a team as a code owner November 6, 2023 15:01
Copy link
Member

@burkedavison burkedavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve with request to remove System.out.printlns

@mpeddada1 mpeddada1 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 6, 2023
@mpeddada1 mpeddada1 added the kokoro:run Add this label to force Kokoro to re-run the tests. label Nov 6, 2023
@mpeddada1 mpeddada1 added kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Nov 7, 2023
@mpeddada1 mpeddada1 added kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Nov 7, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 7, 2023
@mpeddada1 mpeddada1 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 7, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 7, 2023
@mpeddada1 mpeddada1 merged commit 1acedf7 into main Nov 9, 2023
@mpeddada1 mpeddada1 deleted the native-image-http-client branch November 9, 2023 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: xl Pull request size is extra large.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants