Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot parse JSON with big integers #664

Closed
3 tasks done
chingor13 opened this issue May 31, 2019 · 0 comments
Closed
3 tasks done

Cannot parse JSON with big integers #664

chingor13 opened this issue May 31, 2019 · 0 comments
Assignees
@chingor13
Labels
priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. release blocking Required feature/issue must be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@chingor13
Copy link
Collaborator

chingor13 commented May 31, 2019 •
edited
Loading

Found this when trying to upgrade the http client in the auth library.

Caused by #529. If the token looks like an integer we now try to parse it as an integer. This number can overflow an integer and make the parser blow up. Additionally, it changed the expected return type which breaks many internal customers.

googleapis/google-auth-library-java#249

TODO:
@chingor13 chingor13 added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. labels May 31, 2019
@chingor13 chingor13 mentioned this issue May 31, 2019
Merged
@chingor13 chingor13 self-assigned this May 31, 2019
@chingor13 chingor13 added the release blocking Required feature/issue must be fixed prior to next release. label May 31, 2019
@chingor13 chingor13 mentioned this issue May 31, 2019
Merged
clundin25 pushed a commit to clundin25/google-http-java-client that referenced this issue Aug 11, 2022
@TimurSadykov
build: configure branch 0.25.2-sp as a release branch (googleapis#664)
3d5195a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chingor13 chingor13

Labels
priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. release blocking Required feature/issue must be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@chingor13