feat: run the generator – fewer oneOf types, 12/07/2020 #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Grant Timmerman <timmerman+devrel@google.com>
google-cla
bot
added
the
cla: yes
product-auto-label
bot
added
the
api: eventarc
jskeet
approved these changes
Dec 8, 2020
jskeet
left a comment
jskeet
left a comment
There was a problem hiding this comment.
Happy for this to be merged as the current generator results, but I'm really concerned about the types here.
src/main/java/com/google/events/cloud/audit/v1/DestinationAttributes.java
Outdated
Show resolved
Hide resolved
| * time limit and will be allowed to continue to run until either it completes | ||
| * or the build itself times out. | ||
| */ | ||
| public class StepTimeout { |
There was a problem hiding this comment.
If we get a new class every time a google.protobuf.Duration is used, that's going to be a terrible user experience.
Contributor
Author
There was a problem hiding this comment.
Started an email thread to talk about this concern.
Signed-off-by: Grant Timmerman <timmerman+devrel@google.com>
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Jan 26, 2021
🤖 I have created a release \*beep\* \*boop\* --- ## [0.2.0](https://www.github.com/googleapis/google-cloudevents-java/compare/v0.1.5...v0.2.0) (2021-01-26) ### Features * run the generator – fewer oneOf types, 12/07/2020 ([#54](https://www.github.com/googleapis/google-cloudevents-java/issues/54)) ([615e3e7](https://www.github.com/googleapis/google-cloudevents-java/commit/615e3e72f07a2918bd68f244e537948e3aa8ec33)) ### Documentation * update doc install instructions ([#56](https://www.github.com/googleapis/google-cloudevents-java/issues/56)) ([55f551a](https://www.github.com/googleapis/google-cloudevents-java/commit/55f551a06bae742cf33c3e0346de6b7239d33b31)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Runs the generator.
This update should include: