Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): fix go version min dependency for failing builds #267

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

grayside
Copy link
Contributor

@grayside grayside commented Aug 6, 2024

The current model for support of protobuf any type appears to require at least go 1.18, but we are overdue to update to go 1.20 anyway. Fixes this addresses nightly build failures like #207.

@grayside grayside requested a review from a team as a code owner August 6, 2024 18:24
@grayside grayside self-assigned this Aug 6, 2024
@product-auto-label product-auto-label bot added the api: eventarc Issues related to the googleapis/google-cloudevents-go API. label Aug 6, 2024
@grayside grayside requested a review from iennae August 6, 2024 18:24
Copy link
Contributor

@iennae iennae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@grayside grayside merged commit 6f31753 into main Aug 6, 2024
7 checks passed
@grayside grayside deleted the fix-builds-go117 branch August 6, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: eventarc Issues related to the googleapis/google-cloudevents-go API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants