Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove library version from test headers #175

Merged
merged 2 commits into from
Jun 22, 2023
Merged

fix: Remove library version from test headers #175

merged 2 commits into from
Jun 22, 2023

Conversation

muncus
Copy link
Contributor

@muncus muncus commented Jun 22, 2023

This checksum creates diffs on every test file, on every generator run (e.g. #173 ). This makes it hard to spot the substantial changes.

Removing this for now to make reviewing these prs simpler.

part of #168

This checksum creates diffs on every test file, on every generator run (e.g. #173 ). This makes it hard to spot the substantial changes.

Removing this for now to make reviewing these prs simpler.

part of #168
@muncus muncus requested a review from a team as a code owner June 22, 2023 22:26
@product-auto-label product-auto-label bot added the api: eventarc Issues related to the googleapis/google-cloudevents-go API. label Jun 22, 2023
Copy link
Contributor

@grayside grayside left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a standard around including tooling versioning, but removing this until we have smarter versioning makes sense.

@muncus muncus merged commit 86fd204 into main Jun 22, 2023
@muncus muncus deleted the shrink-diffs branch June 22, 2023 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: eventarc Issues related to the googleapis/google-cloudevents-go API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants