refactor(storage): client is templated on stubs #3167
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the work for #2041
Template the
client::Storageon thestub::Storageimplementing it. I useSforStub, and because no other generics usedS. That kept the diff in check.The default template is a
transport::Storagein the client and the builders. This means code like:let client: Storage = Storage::builder().build().awaitkeeps working as before.The
builder()method is only available on the "real" client. It only ever gives you a real client.We need to make the default template type public, although it does not need to be name-able by applications.
The next PR will add the
client::Storage::from_stub()method and make sure all types likeRequestOptionsare name-able outside of the crate.