Skip to content

Conversation

@dbolduc
Copy link
Member

@dbolduc dbolduc commented Aug 28, 2025

Part of the work for #2041

Implement the client::Storage using the transport::Storage stub. The next PR will genericize the stub.

On RequestOptions....

We need to hold onto the client options. In GAPICs, the transport stub will check if a given request option is supplied, and if not, it will use its own. All the types are Option<T>.

At the moment in storage, we have actual types that we default. So every request option passed along to the transport stub has a value. We would overwrite the client options (unless we store options in the client, and use those to initialize the builder).

@product-auto-label product-auto-label bot added the api: storage Issues related to the Cloud Storage API. label Aug 28, 2025
@codecov
Copy link

codecov bot commented Aug 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.41%. Comparing base (6a2b52a) to head (cd36157).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3164   +/-   ##
=======================================
  Coverage   96.41%   96.41%           
=======================================
  Files         110      110           
  Lines        4431     4433    +2     
=======================================
+ Hits         4272     4274    +2     
  Misses        159      159           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dbolduc dbolduc marked this pull request as ready for review August 28, 2025 18:30
@dbolduc dbolduc requested a review from a team as a code owner August 28, 2025 18:30
@dbolduc dbolduc merged commit b92e1d1 into googleapis:main Aug 28, 2025
24 checks passed
@dbolduc dbolduc deleted the refactor-storage-client-uses-transport-stub branch August 28, 2025 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storage Issues related to the Cloud Storage API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants