refactor(storage): client uses transport stub #3164
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the work for #2041
Implement the
client::Storageusing thetransport::Storagestub. The next PR will genericize the stub.On
RequestOptions....We need to hold onto the client options. In GAPICs, the transport stub will check if a given request option is supplied, and if not, it will use its own. All the types are
Option<T>.At the moment in storage, we have actual types that we default. So every request option passed along to the transport stub has a value. We would overwrite the client options (unless we store options in the client, and use those to initialize the builder).