Skip to content

Conversation

@dbolduc
Copy link
Member

@dbolduc dbolduc commented Aug 28, 2025

Part of the work for #2041

Implement WriteObject using the transport::Storage stub.

Similarly to the ReadObject change, we had test helpers on the builder that would no longer have access to the real implementation details (the StorageInner, hidden in the transport stub). Again, we take the request and options from the builder, and combine it with an inner from outside the builder.

@product-auto-label product-auto-label bot added the api: storage Issues related to the Cloud Storage API. label Aug 28, 2025
@codecov
Copy link

codecov bot commented Aug 28, 2025

Codecov Report

❌ Patch coverage is 95.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 96.41%. Comparing base (26cd2c9) to head (5344e89).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/storage/src/storage/perform_upload/tests.rs 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3161      +/-   ##
==========================================
- Coverage   96.42%   96.41%   -0.02%     
==========================================
  Files         110      110              
  Lines        4420     4431      +11     
==========================================
+ Hits         4262     4272      +10     
- Misses        158      159       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dbolduc dbolduc marked this pull request as ready for review August 28, 2025 16:34
@dbolduc dbolduc requested a review from a team as a code owner August 28, 2025 16:34
@dbolduc dbolduc merged commit 6a2b52a into googleapis:main Aug 28, 2025
24 checks passed
@dbolduc dbolduc deleted the storage-write-object-transport-stub branch August 28, 2025 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storage Issues related to the Cloud Storage API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants