refactor(storage): use WriteObjectRequest
#3159
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: storage
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3159 +/- ##
==========================================
- Coverage 96.42% 96.39% -0.03%
==========================================
Files 109 109
Lines 4414 4414
==========================================
- Hits 4256 4255 -1
- Misses 158 159 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
coryan
approved these changes
Aug 28, 2025
Comment on lines
+785
to
+786
| self.request.spec, | ||
| self.request.params, |
Collaborator
There was a problem hiding this comment.
Seems like PerformUpload should keep these aggregated then?
Member
Author
There was a problem hiding this comment.
It could. I did not plan to change it though.
coryan
pushed a commit
to coryan/google-cloud-rust
that referenced
this pull request
Aug 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the work for #2041
We have the
WriteObjectRequest(which is just aspecandparams), might as well use it to hold thespecandparamsfields.