refactor(storage): Checksum as an option #3153
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the work for #2041
Fold
ChecksumintoRequestOptions. This means we do not need to includeChecksumas a parameter in the stub signatures.The
RequestOptionscould/should hold an enum representing the checksum config that only gets turned into an engine when the engine is actually needed. We can do that later.Also while we are here, make all the fields of
RequestOptionscrate-private. This gives us leeway to change the types if we makeRequestOptionspublic.