Skip to content

Conversation

@dbolduc
Copy link
Member

@dbolduc dbolduc commented Aug 28, 2025

Part of the work for #2041

Fold Checksum into RequestOptions. This means we do not need to include Checksum as a parameter in the stub signatures.

The RequestOptions could/should hold an enum representing the checksum config that only gets turned into an engine when the engine is actually needed. We can do that later.

Also while we are here, make all the fields of RequestOptions crate-private. This gives us leeway to change the types if we make RequestOptions public.

@product-auto-label product-auto-label bot added the api: storage Issues related to the Cloud Storage API. label Aug 28, 2025
@codecov
Copy link

codecov bot commented Aug 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.53%. Comparing base (98ea476) to head (f26c819).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3153      +/-   ##
==========================================
+ Coverage   96.50%   96.53%   +0.02%     
==========================================
  Files         108      108              
  Lines        4411     4410       -1     
==========================================
  Hits         4257     4257              
+ Misses        154      153       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dbolduc dbolduc marked this pull request as ready for review August 28, 2025 04:52
@dbolduc dbolduc requested a review from a team as a code owner August 28, 2025 04:52
@dbolduc dbolduc merged commit 7486026 into googleapis:main Aug 28, 2025
24 checks passed
@dbolduc dbolduc deleted the refactor-storage-checksum-as-option branch August 28, 2025 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storage Issues related to the Cloud Storage API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants