Skip to content

Conversation

@coryan
Copy link
Collaborator

@coryan coryan commented Aug 26, 2025

Fixes #3107 and fixes #3024

coryan added 2 commits August 26, 2025 19:05
Use https://github.com/googleapis/google-cloud-cpp/blob/main/google/cloud/storage/examples/storage_bucket_iam_samples.cc
translate the storage_remove_bucket_iam_member and storage_remove_bucket_conditional_iam_binding to Rust.
Use `cargo build -p storage-samples` to verify the code compiles, and `cargo fmt -p storage-samples`.
group these new examples with other bucket IAM examples
@product-auto-label product-auto-label bot added the api: storage Issues related to the Cloud Storage API. label Aug 26, 2025
@codecov
Copy link

codecov bot commented Aug 26, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.50%. Comparing base (3785e9f) to head (01d531c).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3145   +/-   ##
=======================================
  Coverage   96.50%   96.50%           
=======================================
  Files         108      108           
  Lines        4407     4407           
=======================================
  Hits         4253     4253           
  Misses        154      154           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@coryan coryan marked this pull request as ready for review August 26, 2025 23:59
@coryan coryan requested a review from a team as a code owner August 26, 2025 23:59
@coryan coryan merged commit a1a32e7 into googleapis:main Aug 27, 2025
24 checks passed
@coryan coryan deleted the pr10-docs-storage-more-bucket-iam-samples branch August 27, 2025 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storage Issues related to the Cloud Storage API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

storage_remove_bucket_conditional_iam_binding storage_remove_bucket_iam_member

2 participants