Skip to content

Conversation

@coryan
Copy link
Collaborator

@coryan coryan commented Aug 26, 2025

Fixes #3125. Basically we needed to fix sidekick and regenerate the code.

@product-auto-label product-auto-label bot added the api: storage Issues related to the Cloud Storage API. label Aug 26, 2025
@coryan coryan marked this pull request as ready for review August 26, 2025 01:32
@coryan coryan requested a review from a team as a code owner August 26, 2025 01:32
@coryan coryan enabled auto-merge (squash) August 26, 2025 01:36
@codecov
Copy link

codecov bot commented Aug 26, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.50%. Comparing base (42c196d) to head (f32cd9f).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3132      +/-   ##
==========================================
- Coverage   96.52%   96.50%   -0.03%     
==========================================
  Files         107      107              
  Lines        4402     4402              
==========================================
- Hits         4249     4248       -1     
- Misses        153      154       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@coryan coryan merged commit 83988f0 into googleapis:main Aug 26, 2025
23 checks passed
@coryan coryan deleted the chore-update-librarian branch August 26, 2025 01:51
# googleapis SHA.
- name: Regenerate existing clients
run: go run github.com/googleapis/librarian/cmd/sidekick@v0.1.2-0.20250812135937-eb593463c88c refreshall -project-root dart
run: go run github.com/googleapis/librarian/cmd/sidekick@v0.1.2-0.20250826011555-c0c043b7a0a6 refreshall -project-root dart
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given a commit in googleapis/librarian, how do I know the right reference value to use here (i.e., 20250826011555-c0c043b7a0a6)?

Also, do we want to keep the two librarian repo references here - in generator_dart.yaml and sdk.yaml - in sync?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given a commit in googleapis/librarian, how do I know the right reference value to use here (i.e., 20250826011555-c0c043b7a0a6)?

That we just figured out today:

https://github.com/googleapis/google-cloud-rust/blob/main/doc/contributor/howto-guide-generated-code-maintenance.md#special-cases

Also, do we want to keep the two librarian repo references here - in generator_dart.yaml and sdk.yaml - in sync?

Good question ... let's see how it goes by trying to keep them in sync. If it becomes a problem we can change our minds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storage Issues related to the Cloud Storage API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Generated code for LROs uses incorrect service

3 participants