Skip to content

Conversation

@coryan
Copy link
Collaborator

@coryan coryan commented Aug 23, 2025

Generally I bumped the minimal version to whatever is current. In a couple of
places I just changed the code because it looked bad too. I also created a new
build to test these minimal versions.

@codecov
Copy link

codecov bot commented Aug 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.57%. Comparing base (9987f27) to head (fa72016).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3008      +/-   ##
==========================================
- Coverage   96.59%   96.57%   -0.03%     
==========================================
  Files         106      106              
  Lines        4376     4376              
==========================================
- Hits         4227     4226       -1     
- Misses        149      150       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@coryan coryan marked this pull request as ready for review August 23, 2025 19:57
@coryan coryan requested review from a team as code owners August 23, 2025 19:57
dbolduc
dbolduc previously approved these changes Aug 25, 2025
coryan added 4 commits August 25, 2025 09:27
Generally I bumped the minimal version to whatever is current. In a couple of
places I just changed the code because it looked bad too. I also created a new
build to test these minimal versions.
@coryan coryan force-pushed the test-verify-minimal-versions-work branch from 2b74eeb to fa72016 Compare August 25, 2025 13:27
@coryan
Copy link
Collaborator Author

coryan commented Aug 25, 2025

PTAL, I had to rebase the PR.

@coryan coryan merged commit 0d9dd39 into googleapis:main Aug 25, 2025
24 checks passed
@coryan coryan deleted the test-verify-minimal-versions-work branch August 25, 2025 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants