-
Notifications
You must be signed in to change notification settings - Fork 103
cleanup(gax)!: group retry policy arguments #3007
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cleanup(gax)!: group retry policy arguments #3007
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3007 +/- ##
==========================================
- Coverage 96.59% 96.49% -0.10%
==========================================
Files 106 107 +1
Lines 4376 4396 +20
==========================================
+ Hits 4227 4242 +15
- Misses 149 154 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dbolduc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I think this needs a rebase though to pick up the retry policy added to w1r3
Use a struct for the retry policy arguments. This will make it possible to add new fields to the struct without breaking any existing policies, even those written by customers.
740f1a0 to
ab82884
Compare
coryan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PTAL.
Use a struct for the retry policy arguments. This will make it possible
to add new fields to the struct without breaking any existing policies,
even those written by customers.
This could help with #2495, and it is a pre-requisite for making the retry policy APIs public.