Skip to content

Conversation

@coryan
Copy link
Collaborator

@coryan coryan commented Aug 23, 2025

Use a struct for the retry policy arguments. This will make it possible
to add new fields to the struct without breaking any existing policies,
even those written by customers.

This could help with #2495, and it is a pre-requisite for making the retry policy APIs public.

@codecov
Copy link

codecov bot commented Aug 23, 2025

Codecov Report

❌ Patch coverage is 87.50000% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 96.49%. Comparing base (9987f27) to head (642b95f).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/storage/examples/src/lib.rs 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3007      +/-   ##
==========================================
- Coverage   96.59%   96.49%   -0.10%     
==========================================
  Files         106      107       +1     
  Lines        4376     4396      +20     
==========================================
+ Hits         4227     4242      +15     
- Misses        149      154       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@coryan coryan marked this pull request as ready for review August 23, 2025 19:58
@coryan coryan requested review from a team as code owners August 23, 2025 19:58
Copy link
Member

@dbolduc dbolduc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I think this needs a rebase though to pick up the retry policy added to w1r3

@coryan coryan force-pushed the cleanup-gax-bang-retry-policy-arguments branch from 740f1a0 to ab82884 Compare August 25, 2025 13:48
Copy link
Collaborator Author

@coryan coryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PTAL.

@coryan coryan merged commit 6ba7db7 into googleapis:main Aug 25, 2025
23 checks passed
@coryan coryan deleted the cleanup-gax-bang-retry-policy-arguments branch August 25, 2025 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants