feat(storage): implement Clone and Display for KeyAes256 and add examples for using CSEK #3004
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: storage
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3004 +/- ##
==========================================
- Coverage 96.51% 96.49% -0.03%
==========================================
Files 107 107
Lines 4396 4398 +2
==========================================
+ Hits 4243 4244 +1
- Misses 153 154 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
coryan
reviewed
Aug 23, 2025
Collaborator
coryan
left a comment
coryan
left a comment
There was a problem hiding this comment.
A few nits and thoughts for you to consider.
I also updated the description, you need a fixes #blah for each blah.
…lementations to KeyAes256
…into encrypted_storage_samples
suzmue
force-pushed
the
encrypted_storage_samples
branch
from
dfc5d1c to
1196971
Compare
Collaborator
Author
|
@coryan Making the changes you suggested revealed a couple of places that make |
suzmue
changed the title
coryan
approved these changes
Aug 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2975, fixes #2976, fixes #2977, and fixes #3042