fix(storage): more retryable errors #2949
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: storage
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2949 +/- ##
=======================================
Coverage 96.71% 96.71%
=======================================
Files 105 105
Lines 4353 4356 +3
=======================================
+ Hits 4210 4213 +3
Misses 143 143 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gRPC reports some I/O errors as `is_transport()` (because they may include headers, whereas `is_io()` does not). We need to retry them. Over gRPC, Cloud Storage reports some internal as `DeadlineExceeded`, need to retry those too. And finally, timeouts are common enough that need to be retried.
coryan
force-pushed
the
fix-storage-missing-transient-errors
branch
from
4040042 to
76a1db9
Compare
dbolduc
previously approved these changes
Aug 22, 2025
src/storage/src/retry_policy.rs
Outdated
| } | ||
| if error.is_transport() && error.http_status_code().is_none() { | ||
| // Sometimes gRPC returns a transport error without an HTTP status | ||
| // code. We treat all of these are I/O errors and therefore |
dbolduc
approved these changes
Aug 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gRPC reports some I/O errors as
is_transport()(because they mayinclude headers, whereas
is_io()does not). We need to retry them.Over gRPC, Cloud Storage reports some internal as
DeadlineExceeded,need to retry those too.
And finally, timeouts are common enough that need to be retried.
Motivated by #2824