Skip to content

Conversation

@dbolduc
Copy link
Member

@dbolduc dbolduc commented Aug 20, 2025

Fixes #2889

I am open to a shorter module name. Just read_object?

@codecov
Copy link

codecov bot commented Aug 20, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.71%. Comparing base (e836fe5) to head (09829b7).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2942   +/-   ##
=======================================
  Coverage   96.71%   96.71%           
=======================================
  Files         105      105           
  Lines        4353     4353           
=======================================
  Hits         4210     4210           
  Misses        143      143           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dbolduc dbolduc marked this pull request as ready for review August 20, 2025 23:09
@dbolduc dbolduc requested a review from a team as a code owner August 20, 2025 23:09
@suzmue
Copy link
Collaborator

suzmue commented Aug 21, 2025

I see the issue says to move it to its own module, but I'm wondering if this would be appropriate to include in model_ext instead to have less places for looking for types.

I am open to a shorter module name. Just read_object?
+1 for just read_object

@coryan
Copy link
Collaborator

coryan commented Aug 21, 2025

I see the issue says to move it to its own module, but I'm wondering if this would be appropriate to include in model_ext instead to have less places for looking for types.

We have kept traits outside model and model_ext. Maybe we shouldn't....

I am open to a shorter module name. Just read_object?
+1 for just read_object

Meeee toooo. I am stuck in meetings, please make a decision and let me know.

@suzmue
Copy link
Collaborator

suzmue commented Aug 21, 2025

We have kept traits outside model and model_ext. Maybe we shouldn't....

Ok, sticking with our norms SGTM. Rename to read_object and it LGTM

@dbolduc dbolduc force-pushed the read-object-response-module branch from 23fe4a4 to 09829b7 Compare August 22, 2025 15:10
@dbolduc
Copy link
Member Author

dbolduc commented Aug 22, 2025

Rename to read_object

Done.

I think model_ext also made sense as it's kind of a return type.

@dbolduc dbolduc merged commit 537b261 into googleapis:main Aug 22, 2025
23 checks passed
@dbolduc dbolduc deleted the read-object-response-module branch August 22, 2025 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move ReadObjectResponse to its own module

3 participants