Skip to content

Conversation

@coryan
Copy link
Collaborator

@coryan coryan commented Aug 20, 2025

Resumable uploads are enabled for sizes greater than or equal to
the threshold. If we want to guarantee single-shot uploads we need to
make the threshold larger than the size.

Motivated by #2824

Resumable uploads are enabled for sizes greater than **or equal** to
the threshold. If we want to guarantee single-shot uploads we need to
make the threshold *larger* than the size.
@product-auto-label product-auto-label bot added the api: storage Issues related to the Cloud Storage API. label Aug 20, 2025
@codecov
Copy link

codecov bot commented Aug 20, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.17%. Comparing base (f5ffd2b) to head (6839bd1).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2938   +/-   ##
=======================================
  Coverage   96.17%   96.17%           
=======================================
  Files         105      105           
  Lines        4394     4394           
=======================================
  Hits         4226     4226           
  Misses        168      168           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@coryan coryan marked this pull request as ready for review August 20, 2025 14:33
@coryan coryan requested a review from a team as a code owner August 20, 2025 14:33
@coryan coryan merged commit 5c4f786 into googleapis:main Aug 20, 2025
23 checks passed
@coryan coryan deleted the pr7-fix-w1r3-correct-threshold-for-resumable-uploads branch August 20, 2025 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storage Issues related to the Cloud Storage API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants