Skip to content

fix(storage): preconditions in single-shot uploads #2925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
coryan merged 2 commits into from
Aug 19, 2025
Merged

fix(storage): preconditions in single-shot uploads #2925

coryan merged 2 commits into from
Aug 19, 2025

Conversation

@coryan
Copy link
Collaborator

@coryan coryan commented Aug 19, 2025

Motivated by #2824

@product-auto-label product-auto-label bot added the api: storage Issues related to the Cloud Storage API. label Aug 19, 2025
@codecov
Copy link

codecov bot commented Aug 19, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.17%. Comparing base (19d8a87) to head (ef36baf).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2925   +/-   ##
=======================================
  Coverage   96.17%   96.17%           
=======================================
  Files         105      105           
  Lines        4392     4393    +1     
=======================================
+ Hits         4224     4225    +1     
  Misses        168      168

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@coryan coryan marked this pull request as ready for review August 19, 2025 05:33
@coryan coryan requested a review from a team as a code owner August 19, 2025 05:33
dbolduc
dbolduc previously approved these changes Aug 19, 2025
View reviewed changes
Copy link
Member

@dbolduc dbolduc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just copy/paste cleanups

coryan
coryan commented Aug 19, 2025
View reviewed changes
Copy link
Collaborator Author

@coryan coryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PTAL

@coryan coryan enabled auto-merge (squash) August 19, 2025 15:36
@coryan coryan merged commit f7e26a2 into googleapis:main Aug 19, 2025
23 checks passed
@coryan coryan deleted the fix-storage-preconditions-for-single-shot-uploads branch August 19, 2025 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dbolduc dbolduc dbolduc approved these changes

Assignees

No one assigned

Labels

api: storage Issues related to the Cloud Storage API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@coryan @dbolduc