cleanup(storage)!: ranged reads made type-safe #2924
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2924 +/- ##
==========================================
+ Coverage 96.17% 96.19% +0.01%
==========================================
Files 105 105
Lines 4394 4411 +17
==========================================
+ Hits 4226 4243 +17
Misses 168 168 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Specify ranged reads using a safe type, which does not permit invalid ranges (such as negative length limits). No need to have a `ReadError` if the request is well-defined by construction.
coryan
force-pushed
the
cleanup-storage-bang-safe-read-range-enum
branch
from
fe01211 to
086e388
Compare
dbolduc
reviewed
Aug 20, 2025
Member
dbolduc
left a comment
dbolduc
left a comment
There was a problem hiding this comment.
Looks good, but there might be a bug predating this PR for the tail case
dbolduc
approved these changes
Aug 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specify ranged reads using a safe type, which does not permit invalid
ranges (such as negative length limits). No need to have a
ReadErrorif the request is well-defined by construction.
Fixes #2849