cleanup(storage)!: rename RecommendedPolicy
#2916
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2916 +/- ##
=======================================
Coverage 96.16% 96.16%
=======================================
Files 105 105
Lines 4384 4384
=======================================
Hits 4216 4216
Misses 168 168 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
The name implied that no decorators were needed to use the policy, but they are. One needs to set limits on the number of retry attempts. Fix formatting
coryan
force-pushed
the
cleanup-storage-bang-rename-retry-policies
branch
from
6c5a190 to
c78a9ff
Compare
dbolduc
approved these changes
Aug 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The name implied that no decorators were needed to use the policy, but
they are. One needs to set limits on the number of retry attempts.
Fixes #2893