Skip to content

Conversation

@coryan
Copy link
Collaborator

@coryan coryan commented Aug 18, 2025

Eagerly connecting to the client results in transient errors, and we
don't have a retry loop in the client creation. Instead of adding
another retry loop (and another set of configurations), we delay the
connection until the first request.

Fixes #2914

Eagerly connecting to the client results in transient errors, and we
don't have a retry loop in the client creation. Instead of adding
another retry loop (and another set of configurations), we delay the
connection until the first request.
@codecov
Copy link

codecov bot commented Aug 18, 2025

Codecov Report

❌ Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 96.17%. Comparing base (66519b4) to head (f2d83ec).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
src/gax-internal/tests/grpc_timeout.rs 88.88% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2915   +/-   ##
=======================================
  Coverage   96.16%   96.17%           
=======================================
  Files         105      105           
  Lines        4384     4392    +8     
=======================================
+ Hits         4216     4224    +8     
  Misses        168      168           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@coryan coryan marked this pull request as ready for review August 18, 2025 13:34
@coryan coryan requested a review from a team as a code owner August 18, 2025 13:34
dbolduc
dbolduc previously approved these changes Aug 18, 2025
Copy link
Member

@dbolduc dbolduc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, because it is a good fix. I suspect the timeout tests can be cleaned up a bit, though.

Copy link
Collaborator Author

@coryan coryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PTAL

@coryan coryan merged commit 2523e2b into googleapis:main Aug 18, 2025
23 checks passed
@coryan coryan deleted the fix-gax-internal-use-connect-lazy branch August 18, 2025 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Change gRPC clients to use connect_lazy()

2 participants