-
Notifications
You must be signed in to change notification settings - Fork 103
fix(gax-internal): lazy connects for gRPC clients #2915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(gax-internal): lazy connects for gRPC clients #2915
Conversation
Eagerly connecting to the client results in transient errors, and we don't have a retry loop in the client creation. Instead of adding another retry loop (and another set of configurations), we delay the connection until the first request.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2915 +/- ##
=======================================
Coverage 96.16% 96.17%
=======================================
Files 105 105
Lines 4384 4392 +8
=======================================
+ Hits 4216 4224 +8
Misses 168 168 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dbolduc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, because it is a good fix. I suspect the timeout tests can be cleaned up a bit, though.
coryan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PTAL
Eagerly connecting to the client results in transient errors, and we
don't have a retry loop in the client creation. Instead of adding
another retry loop (and another set of configurations), we delay the
connection until the first request.
Fixes #2914