cleanup(storage)!: rename with_* setters

[coryan]

In all the GAPICs we use set_*() to set fields in the request and
with_*() to set options (like retry policies) for the request. We
believe that making the storage client consistent will pay off in the
long term.

Fixes #2891

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.16%. Comparing base (66519b4) to head (b065d46).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2913   +/-   ##
=======================================
  Coverage   96.16%   96.16%           
=======================================
  Files         105      105           
  Lines        4384     4384           
=======================================
  Hits         4216     4216           
  Misses        168      168           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.