Skip to content

Conversation

@coryan
Copy link
Collaborator

@coryan coryan commented Aug 15, 2025

Fixes #2897

@codecov
Copy link

codecov bot commented Aug 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.86%. Comparing base (84e7561) to head (17ab18b).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2905   +/-   ##
=======================================
  Coverage   94.86%   94.86%           
=======================================
  Files         104      105    +1     
  Lines        4339     4339           
=======================================
  Hits         4116     4116           
  Misses        223      223           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@coryan coryan marked this pull request as ready for review August 15, 2025 19:44
@coryan coryan requested a review from a team as a code owner August 15, 2025 19:44
suzmue
suzmue previously approved these changes Aug 15, 2025
@coryan coryan force-pushed the cleanup-storage-bang-move-aes-key-256 branch from 4ab0237 to 17ab18b Compare August 15, 2025 20:08
Copy link
Contributor

@whuffman36 whuffman36 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coryan coryan merged commit a14ae6e into googleapis:main Aug 15, 2025
23 checks passed
@coryan coryan deleted the cleanup-storage-bang-move-aes-key-256 branch August 15, 2025 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move AesKey256 to model::request_helpers module

3 participants