Skip to content

Conversation

@coryan
Copy link
Collaborator

@coryan coryan commented Aug 15, 2025

And the related types, updated all the documentation and comments to use
read instead of download.

Fixes #2888

And the related types, updated all the documentation and comments to use
`read` instead of `download`.
@coryan coryan marked this pull request as ready for review August 15, 2025 15:03
@coryan coryan requested a review from a team as a code owner August 15, 2025 15:03
@codecov
Copy link

codecov bot commented Aug 15, 2025

Codecov Report

❌ Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 94.86%. Comparing base (a1b3758) to head (3d84efa).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
src/storage/src/storage/read_object.rs 88.88% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2903   +/-   ##
=======================================
  Coverage   94.86%   94.86%           
=======================================
  Files         104      104           
  Lines        4339     4339           
=======================================
  Hits         4116     4116           
  Misses        223      223           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@coryan coryan merged commit 84e7561 into googleapis:main Aug 15, 2025
23 checks passed
@coryan coryan deleted the cleanup-storage-bang-rename-resume-policy branch August 15, 2025 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rename download_resume_policy to **read_**resume_policy

2 participants