Skip to content

Conversation

@coryan
Copy link
Collaborator

@coryan coryan commented Aug 12, 2025

Only errors that come from the user should abort an upload. Other errors
are I/O errors and should allow the upload to continue (subject to the
retry or resume policies).

part of the work for #2811

Only errors that come from the user should abort an upload. Other errors
are I/O errors and should allow the upload to continue (subject to the
retry or resume policies).
@product-auto-label product-auto-label bot added the api: storage Issues related to the Cloud Storage API. label Aug 12, 2025
@codecov
Copy link

codecov bot commented Aug 12, 2025

Codecov Report

❌ Patch coverage is 86.66667% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 94.91%. Comparing base (f5505ac) to head (6c0ed46).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
src/storage/src/storage/perform_upload/buffered.rs 84.61% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2873   +/-   ##
=======================================
  Coverage   94.90%   94.91%           
=======================================
  Files         103      103           
  Lines        4320     4326    +6     
=======================================
+ Hits         4100     4106    +6     
  Misses        220      220           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@coryan coryan marked this pull request as ready for review August 12, 2025 17:15
@coryan coryan requested a review from a team as a code owner August 12, 2025 17:15
@coryan coryan merged commit d3d7d84 into googleapis:main Aug 12, 2025
23 checks passed
@coryan coryan deleted the fix-storage-more-io-errors branch August 12, 2025 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storage Issues related to the Cloud Storage API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants