Skip to content

Conversation

@coryan
Copy link
Collaborator

@coryan coryan commented Aug 12, 2025

When uploading an object we return an error if the resulting object
checksums do not match the computed or expected checksums. We should
include the object metadata in the error, as the object was created.

Fixes #2855

When uploading an object we return an error if the resulting object
checksums do not match the computed or expected checksums. We should
include the object metadata in the error, as the object was created.
@coryan coryan marked this pull request as ready for review August 12, 2025 14:08
@coryan coryan requested a review from a team as a code owner August 12, 2025 14:08
@codecov
Copy link

codecov bot commented Aug 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.91%. Comparing base (a9fe494) to head (89fa048).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2871      +/-   ##
==========================================
- Coverage   94.98%   94.91%   -0.08%     
==========================================
  Files         102      103       +1     
  Lines        4306     4324      +18     
==========================================
+ Hits         4090     4104      +14     
- Misses        216      220       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

dbolduc
dbolduc previously approved these changes Aug 12, 2025
Copy link
Member

@dbolduc dbolduc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

optional: could verify object in the checksum unit tests:

assert!(err.is_serialization(), "{err:?}");

Copy link
Collaborator Author

@coryan coryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

optional: could verify object in the checksum unit tests:

Done. PTAL

@coryan coryan enabled auto-merge (squash) August 12, 2025 16:39
@coryan coryan merged commit 08a26dc into googleapis:main Aug 12, 2025
23 checks passed
@coryan coryan deleted the feat-storage-bang-include-object-in-checksum-errors branch August 12, 2025 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Uploads that fail with a checksum mismatch should return the object

2 participants