Replace manual Speech library with GAPIC and helpers #1977
Conversation
googlebot
added
the
cla: yes
| { | ||
| "title": "Result", | ||
| "type": "google/cloud/speech/result" | ||
| }, | ||
| { |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
FYI I'm trying this out with the samples! |
quartzmo
added
api: speech
|
Blocking for external delivery of additional documentation. |
|
We have made changes since this PR was first created. Can you rebase on master and fix the conflicts? |
|
Rebased. |
|
Is the GAPIC-only Vision release also blocked by the same external documentation requirement that this PR is blocked by? |
|
@blowmage That's correct. |
|
Can we get a ETA on when this PR will be unblocked? |
|
Hi, any update on when this changes would be merged and when we can enable V1.1Beta1 API ? |
|
@jbolinger @Beccca Can we get an ETA on when we can switch to the generated clients? |
blowmage
removed
the
status: blocked
This PR replaces the existing Vision client library with an autogenerated library. The autogenerated code is supplemented with a helper that wraps the autogenerated bidi streaming RPC in the stream class from the old manual library. (Note that this is a divergence from the Python library, but one that should substantially improve the usability of bidi streaming relative to Python.) As such, it substantially changes the public surface. (See also googleapis#1828, googleapis#1959 for analogous changes to Language, Vision.)
The implementation of google-gax has changed, the mocks use that interface.
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
googlebot
added
cla: no
blowmage
added
cla: yes
googlebot
removed
the
cla: yes
|
|
|
I am the author and I rebased the branch to resolve conflicts and fix tests to use the new google-gax API. |
These tests and the helper file are obsolete.
googlebot
added
the
cla: no
jbolinger
added
cla: yes
|
A Googler has manually verified that the CLAs look good. (Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.) |
This PR replaces the existing Vision client library with an
autogenerated library. The autogenerated code is supplemented with a
helper that wraps the autogenerated bidi streaming RPC in the stream
class from the old manual library. (Note that this is a divergence from
the Python library, but one that should substantially improve the
usability of bidi streaming relative to Python.)
As such, it substantially changes the public surface.
(See also #1828, #1959 for analogous changes to Language, Vision.)
cc @jbolinger