Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add autogenerated Bigtable library #1786

Merged
merged 9 commits into from
Oct 25, 2017
Merged

Add autogenerated Bigtable library #1786

merged 9 commits into from
Oct 25, 2017

Conversation

geigerj
Copy link
Contributor

@geigerj geigerj commented Oct 20, 2017 •
edited
Loading

Note: This is not for release. Engineers from the BigTable team will be writing the manual layer for the client library on top of this GAPIC library. They would prefer to develop in master unless there's a reason to work in another branch.

@geigerj
Generate bigtable data API
68f244f
@geigerj
Generate bigtable admin API
83679a6
@geigerj
Fixes for autogen bugs
dffae0a 
- Remove a bad type check
- Rename a conflicting class name
@geigerj geigerj requested review from blowmage and quartzmo October 20, 2017 00:31
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 20, 2017
quartzmo
quartzmo reviewed Oct 20, 2017
View reviewed changes
google-cloud-bigtable/.rubocop.yml Outdated
Exclude:
- "google-cloud-bigtable.gemspec"
- "lib/google/bigtable/v2/**/*"
- "lib/google/cloud/bigtable/v2/**/*"

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@quartzmo quartzmo added the api: bigtable Issues related to the Bigtable API. label Oct 20, 2017
blowmage
blowmage reviewed Oct 23, 2017
View reviewed changes
google-cloud-bigtable/.rubocop.yml Outdated
@@ -2,7 +2,9 @@ AllCops:
Exclude:
- "google-cloud-bigtable.gemspec"
- "lib/google/bigtable/v2/**/*"

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@geigerj
Copy link
Contributor Author

geigerj commented Oct 23, 2017

@blowmage @quartzmo The continued failure seems to be from the jsondoc task.

[error]: Exception occurred while generating 'Google/Cloud/Bigtable.html'
[error]: NoMethodError: undefined method `assoc' for nil:NilClass
[error]: Stack trace:
	/opt/circleci/.rvm/gems/ruby-2.4.0/gems/yard-0.9.9/templates/default/tags/html/tag.erb:13:in `block in _erb_cache_38'
	/opt/circleci/.rvm/gems/ruby-2.4.0/gems/yard-0.9.9/templates/default/tags/html/tag.erb:5:in `each'
	/opt/circleci/.rvm/gems/ruby-2.4.0/gems/yard-0.9.9/templates/default/tags/html/tag.erb:5:in `_erb_cache_38'
	/opt/circleci/.rvm/gems/ruby-2.4.0/gems/yard-0.9.9/lib/yard/templates/template.rb:287:in `erb'
	/opt/circleci/.rvm/gems/ruby-2.4.0/gems/yard-0.9.9/templates/default/tags/setup.rb:29:in `tag'
	/opt/circleci/.rvm/gems/ruby-2.4.0/gems/yard-0.9.9/templates/default/tags/setup.rb:18:in `param'

[error]: Exception occurred while generating 'Google/Cloud/Bigtable/Admin/BigtableInstanceAdmin.html'
[error]: NoMethodError: undefined method `assoc' for nil:NilClass
[error]: Stack trace:
	/opt/circleci/.rvm/gems/ruby-2.4.0/gems/yard-0.9.9/templates/default/tags/html/tag.erb:13:in `block in _erb_cache_38'
	/opt/circleci/.rvm/gems/ruby-2.4.0/gems/yard-0.9.9/templates/default/tags/html/tag.erb:5:in `each'
	/opt/circleci/.rvm/gems/ruby-2.4.0/gems/yard-0.9.9/templates/default/tags/html/tag.erb:5:in `_erb_cache_38'
	/opt/circleci/.rvm/gems/ruby-2.4.0/gems/yard-0.9.9/lib/yard/templates/template.rb:287:in `erb'
	/opt/circleci/.rvm/gems/ruby-2.4.0/gems/yard-0.9.9/templates/default/tags/setup.rb:29:in `tag'
	/opt/circleci/.rvm/gems/ruby-2.4.0/gems/yard-0.9.9/templates/default/tags/setup.rb:18:in `param'

[error]: Exception occurred while generating 'Google/Cloud/Bigtable/Admin/BigtableTableAdmin.html'
[error]: NoMethodError: undefined method `assoc' for nil:NilClass
[error]: Stack trace:
	/opt/circleci/.rvm/gems/ruby-2.4.0/gems/yard-0.9.9/templates/default/tags/html/tag.erb:13:in `block in _erb_cache_38'
	/opt/circleci/.rvm/gems/ruby-2.4.0/gems/yard-0.9.9/templates/default/tags/html/tag.erb:5:in `each'
	/opt/circleci/.rvm/gems/ruby-2.4.0/gems/yard-0.9.9/templates/default/tags/html/tag.erb:5:in `_erb_cache_38'
	/opt/circleci/.rvm/gems/ruby-2.4.0/gems/yard-0.9.9/lib/yard/templates/template.rb:287:in `erb'
	/opt/circleci/.rvm/gems/ruby-2.4.0/gems/yard-0.9.9/templates/default/tags/setup.rb:29:in `tag'
	/opt/circleci/.rvm/gems/ruby-2.4.0/gems/yard-0.9.9/templates/default/tags/setup.rb:18:in `param'

Any idea what this means?

@geigerj
Copy link
Contributor Author

geigerj commented Oct 23, 2017

Never mind -- this appears to be from improper usage of the @overload tag. Not sure why it didn't come up before. On to the next jsondoc error...

@geigerj
Copy link
Contributor Author

geigerj commented Oct 23, 2017

I'm not sure why the CI build is still failing (now in VideoIntelligence). The error message looks like the issue that was fixed in googleapis/gapic-generator#1643, which shouldn't happen in VideoIntelligence, unless the tests are being run in the same environment across gems. It's also unclear to me why this PR would trigger a failure if it was succeeding previously.

@quartzmo
Copy link
Member

From the failed build:

TypeError: superclass mismatch for class MockCredentialsClass

@geigerj Isn't this error a result of the class being defined twice with inheritance?

    Occurrences of 'MockCredentialsClass < ' in Directory /Users/quartzmo/code/google/codez/gcloud-ruby/ with mask '*.rb'
Found Occurrences  (2 usages found)
    google-cloud-video_intelligence/test/google/cloud/video_intelligence/v1beta1  (1 usage found)
        video_intelligence_service_client_test.rb  (1 usage found)
            (56: 7) class MockCredentialsClass < Google::Cloud::VideoIntelligence::Credentials
    google-cloud-video_intelligence/test/test/google/cloud/video_intelligence/v1beta2  (1 usage found)
        video_intelligence_service_client_test.rb  (1 usage found)
            (56: 7) class MockCredentialsClass < Google::Cloud::VideoIntelligence::Credentials

@geigerj
Copy link
Contributor Author

geigerj commented Oct 23, 2017

@quartzmo Right, several of the GAPICs define a class by this name in their unit tests, but does/should the test care if they're defined in different GAPICs? And I'm unsure why this failure didn't come up in the last successful build, which already contains two GAPICs with such unit tests (image_annotator_client_test, video_intelligence_service_client_test)?

@geigerj
Copy link
Contributor Author

geigerj commented Oct 25, 2017

Hooray, CI passes now!

blowmage
blowmage approved these changes Oct 25, 2017
View reviewed changes
Copy link
Contributor

@blowmage blowmage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad to see this green.

@blowmage blowmage merged commit 50fee4e into googleapis:master Oct 25, 2017
@mbrukman mbrukman mentioned this pull request Oct 27, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blowmage blowmage blowmage approved these changes

@quartzmo quartzmo quartzmo approved these changes

Assignees

@blowmage blowmage

@quartzmo quartzmo

Labels
api: bigtable Issues related to the Bigtable API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@geigerj @quartzmo @blowmage @googlebot