Conversation
googlebot
added
the
cla: yes
|
|
||
| if self.client_library_version is not None: | ||
| ua += "gccl/{client_library_version} " | ||
| ua += "gcloud-python/{client_library_version} " |
There was a problem hiding this comment.
Why would we want to repeat the same version with a different prefix?
There was a problem hiding this comment.
The gccl header is the way forward, we have systems that still expect gcloud-python. This is to make sure both legacy and forward systems have data in the form they expect. I will mark this dnm for now.
There was a problem hiding this comment.
ISTM we need to double-check that adding gcloud-python back in doesn't break any of the log parsers expecting the "standard" format.
There was a problem hiding this comment.
It shouldn't be an issue due to the additive nature of the ua strings. That said, I am currently in discussions with some folks.
crwilcox
added
the
do not merge
|
I am closing this. I will open a pr that adds it just to storage |
3 participants
Some metrics systems expect gcloud-{lang}/{library_version}