Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(bigquery): rewrite docs in Google style, part 2 #9481

Merged

Conversation

IlyaFaer
Copy link

towards issue #9092

@IlyaFaer IlyaFaer added the api: bigquery Issues related to the BigQuery API. label Oct 16, 2019
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 16, 2019
@IlyaFaer IlyaFaer marked this pull request as ready for review October 16, 2019 15:23
@IlyaFaer IlyaFaer requested a review from a team October 16, 2019 15:23
@IlyaFaer
Copy link
Author

IlyaFaer commented Oct 16, 2019

This PR contains mostly auto generated (by my self-written script) changes, similar to PR, and a small peace of manual work. No functional changes, only comments update

Copy link
Contributor

@software-dov software-dov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one thing before approval.

core/google/cloud/_http.py Outdated Show resolved Hide resolved
@IlyaFaer IlyaFaer added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 19, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 19, 2019
@IlyaFaer IlyaFaer added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 19, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 19, 2019
Copy link
Contributor

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Apologies for the delay on the review. It didn't show up in my "awaiting your review" list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the BigQuery API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants