Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BigQuery: Revert "Disable failing snippets test" #9220

Merged
merged 1 commit into from
Sep 12, 2019
Merged

BigQuery: Revert "Disable failing snippets test" #9220

merged 1 commit into from
Sep 12, 2019

Conversation

tswast
Copy link
Contributor

@tswast tswast commented Sep 12, 2019

Reverts #9156

Per internal issue 140294699:

The bug affects table copy non-cmek into CMEK for tables created a long time ago. Does not affect new tables.

The engineering team has applied a fix for the problematic table bigquery-public-data:samples.shakespeare, so the test in question should now pass.

@tswast tswast requested a review from a team September 12, 2019 16:06
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 12, 2019
@tswast tswast requested a review from plamut September 12, 2019 16:06
@tswast tswast added api: bigquery Issues related to the BigQuery API. type: process A process-related concern. May include testing, release, or the like. labels Sep 12, 2019
plamut
plamut approved these changes Sep 12, 2019
View reviewed changes
Copy link
Contributor

@plamut plamut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay! 🎉

@plamut plamut merged commit 1a2311a into master Sep 12, 2019
emar-kar pushed a commit to MaxxleLLC/google-cloud-python that referenced this pull request Sep 18, 2019
@tswast @emar-kar
Revert "Disable failing snippets test (googleapis#9156)" (googleapis#…
8ed37db 
…9220)

This reverts commit 5a81ea3.
@tseaver tseaver deleted the revert-9156-disable-failing-test branch August 24, 2021 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plamut plamut plamut approved these changes

Assignees
No one assigned
Labels
api: bigquery Issues related to the BigQuery API. cla: yes This human has signed the Contributor License Agreement. type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tswast @plamut @googlebot