BigQuery: Fix BigQuery client unit test assertions #9112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since a timeout argument is now sent with HTTP requests by default, the call assertions need adjustment.
googlebot
added
the
cla: yes
tswast
approved these changes
Aug 27, 2019
HemangChothani
pushed a commit
to HemangChothani/google-cloud-python
that referenced
this pull request
Aug 29, 2019
Since a timeout argument is now sent with HTTP requests by default, the call assertions need adjustment.
emar-kar
pushed a commit
to MaxxleLLC/google-cloud-python
that referenced
this pull request
Sep 18, 2019
Since a timeout argument is now sent with HTTP requests by default, the call assertions need adjustment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of today I noticed that BigQuery unit tests fail on the latest
masterbranch. Ditto for several less recent commits that I tried.The reason is that HTTP requests now contain a
timeout=(61, 60)argument, thus the affected assertions had to be updated. I opted for themock.ANYvalue, because the exact timeout is not significant in the tests. However, please let me know if a concrete value should be used instead.