Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Videointelligence: Add VPC SC integration tests. #8607

Merged
merged 15 commits into from
Jul 11, 2019
Merged

Videointelligence: Add VPC SC integration tests. #8607

merged 15 commits into from
Jul 11, 2019

Conversation

mkudejim
Copy link
Contributor

@mkudejim mkudejim commented Jul 3, 2019

No description provided.

@mkudejim mkudejim requested a review from busunkim96 as a code owner July 3, 2019 18:09
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 3, 2019
@tseaver tseaver changed the title Adds VPC SC integration tests for Video Intelligence API Videointelligence: Add VPC SC integration tests. Jul 3, 2019
@tseaver tseaver added api: videointelligence Issues related to the Video Intelligence API API. testing labels Jul 3, 2019
tseaver
tseaver suggested changes Jul 3, 2019
View reviewed changes
...gle/cloud/videointelligence_v1/gapic/transports/video_intelligence_service_grpc_transport.py Outdated Show resolved Hide resolved
...gle/cloud/videointelligence_v1/gapic/transports/video_intelligence_service_grpc_transport.py Outdated Show resolved Hide resolved
...gle/cloud/videointelligence_v1/gapic/transports/video_intelligence_service_grpc_transport.py Outdated Show resolved Hide resolved
videointelligence/google/cloud/videointelligence_v1/gapic/video_intelligence_service_client.py Outdated Show resolved Hide resolved
videointelligence/google/cloud/videointelligence_v1/gapic/video_intelligence_service_client.py Outdated Show resolved Hide resolved
videointelligence/google/cloud/videointelligence_v1/gapic/video_intelligence_service_client.py Outdated Show resolved Hide resolved
videointelligence/google/cloud/videointelligence_v1/gapic/video_intelligence_service_client.py Outdated Show resolved Hide resolved
videointelligence/google/cloud/videointelligence_v1/gapic/video_intelligence_service_client.py Outdated Show resolved Hide resolved
videointelligence/google/cloud/videointelligence_v1/gapic/video_intelligence_service_client.py Outdated Show resolved Hide resolved
videointelligence/google/cloud/videointelligence_v1/gapic/video_intelligence_service_client.py Outdated Show resolved Hide resolved
@tseaver tseaver added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jul 3, 2019
@busunkim96
Copy link
Contributor

@mkudejim I think your most recent commits added changes to other APIs. Would you mind reverting those changes?

@mkudejim
Copy link
Contributor Author

mkudejim commented Jul 9, 2019

@mkudejim I think your most recent commits added changes to other APIs. Would you mind reverting those changes?

Which changes are you referring to? The commits that are not by me are already merged into master and were pulled in when I pulled from upstream/master.

@busunkim96 busunkim96 added kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Jul 9, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 9, 2019
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Jul 10, 2019
@tseaver
Copy link
Contributor

tseaver commented Jul 10, 2019

@mkudejim Please rebase your branch against master (rather than merging master into it).

@busunkim96 busunkim96 added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Jul 10, 2019
@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@busunkim96 busunkim96 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 10, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 10, 2019
@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@tseaver tseaver added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 10, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 10, 2019
@busunkim96 busunkim96 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 11, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 11, 2019
@busunkim96 busunkim96 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 11, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 11, 2019
@busunkim96 busunkim96 merged commit aba3216 into googleapis:master Jul 11, 2019
@tseaver tseaver mentioned this pull request Jul 12, 2019
Closed
@tseaver
Copy link
Contributor

tseaver commented Jul 12, 2019

@mkudejim, @busunkim96 For future reference, we need to ensure that the changes made to noxfile.py are not overwritten in autogen (see #8661).

@tseaver tseaver mentioned this pull request Jul 12, 2019
Merged
This was referenced Nov 6, 2019
Merged
Closed
parthea pushed a commit that referenced this pull request Sep 22, 2023
@mkudejim @busunkim96
Add VPC SC integration tests. (#8607)
6775357
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tseaver tseaver tseaver requested changes

@busunkim96 busunkim96 busunkim96 approved these changes

@anguillanneuf anguillanneuf Awaiting requested review from anguillanneuf

@crwilcox crwilcox Awaiting requested review from crwilcox

@frankyn frankyn Awaiting requested review from frankyn

@plamut plamut Awaiting requested review from plamut

Assignees
No one assigned
Labels
api: videointelligence Issues related to the Video Intelligence API API. cla: yes This human has signed the Contributor License Agreement. testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mkudejim @busunkim96 @googlebot @tseaver @yoshi-kokoro