Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Phase 1 for storing schemas for later use. #7761

Merged
merged 11 commits into from
Apr 25, 2019
Merged

Phase 1 for storing schemas for later use. #7761

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
9d3198b
Added functions to client for loading and saving schemas to a file.
lbristol88 Apr 20, 2019
894bb26
Tests for schema to/from json.
lbristol88 Apr 20, 2019
136cfcb
Updated functions to close file and made test changes per feedback.
lbristol88 Apr 23, 2019
092e121
Update with review feedback.
lbristol88 Apr 24, 2019
79e965b
Removed unneeded variable
lbristol88 Apr 24, 2019
22bf1ab
Removed append in test
lbristol88 Apr 24, 2019
bb2ca79
Made changes based on feedback
lbristol88 Apr 24, 2019
5451852
Added change to test per feedback.
lbristol88 Apr 24, 2019
f4ae0c1
removed try blocks per suggestion
lbristol88 Apr 24, 2019
5791049
Updated test to pass python 2 version
lbristol88 Apr 24, 2019
fa331c4
fixed tests to work in python 2
lbristol88 Apr 24, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Removed unneeded variable
  • Loading branch information
@lbristol88
lbristol88 committed Apr 24, 2019
commit 79e965ba36a26093280ad36475832699d9b6894b
1 change: 0 additions & 1 deletion bigquery/google/cloud/bigquery/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1974,7 +1974,6 @@ def schema_to_json(self, schema_list, destination):

Destination is a file path or a file object.
"""
file_obj = None
json_schema_list = [f.to_api_repr() for f in schema_list]

if isinstance(destination, io.IOBase):
Expand Down