Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Blob/Bucket reload() public and remove the public interface to _properties #770

Merged
merged 2 commits into from
Mar 30, 2015
Merged

Make Blob/Bucket reload() public and remove the public interface to _properties #770

merged 2 commits into from
Mar 30, 2015

Conversation

dhermes
Copy link
Contributor

@dhermes dhermes commented Mar 28, 2015

No description provided.

@dhermes dhermes added the api: storage Issues related to the Cloud Storage API. label Mar 28, 2015
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 28, 2015
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 87b9bf3 on dhermes:make-reload-public into 4d69bb3 on GoogleCloudPlatform:master.

tseaver
tseaver reviewed Mar 30, 2015
View reviewed changes
gcloud/storage/_helpers.py
@@ -82,7 +73,7 @@ def batch(self):
"""
return _PropertyBatch(self)

def _reload_properties(self):
def reload(self):

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@tseaver
Copy link
Contributor

tseaver commented Mar 30, 2015

LGTM. My question about return self from mutators shouldn't block the merge, but we should be dropping that pattern pretty much everywhere.

@tseaver
Copy link
Contributor

tseaver commented Mar 30, 2015

@dhermes needs rebase?

@dhermes
Copy link
Contributor Author

dhermes commented Mar 30, 2015

@tseaver Rebased and filed the bug about return self.

Will merge on Travis success.

@dhermes
Renaming _reload_properties to public method reload on Blob/Bucket.
5d86096
@dhermes
Removing _PropertyMixin.properties public property.
85aea83 
The blob/bucket metadata was never actually accessed via
the public properties `properties`.
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 85aea83 on dhermes:make-reload-public into * on GoogleCloudPlatform:master*.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 85aea83 on dhermes:make-reload-public into * on GoogleCloudPlatform:master*.

dhermes added a commit that referenced this pull request Mar 30, 2015
@dhermes
Merge pull request #770 from dhermes/make-reload-public
ef22592 
Make Blob/Bucket reload() public and remove the public interface to _properties
@dhermes dhermes merged commit ef22592 into googleapis:master Mar 30, 2015
@dhermes dhermes deleted the make-reload-public branch March 30, 2015 19:59
@dhermes dhermes mentioned this pull request Mar 30, 2015
Merged
@dhermes dhermes mentioned this pull request Apr 9, 2015
Merged
parthea pushed a commit that referenced this pull request Oct 21, 2023
@gcf-owl-bot
feat: Update Compute Engine API to revision 20230307 (#770) (#400)
8a5a57a 
* feat: Update Compute Engine API to revision 20230307 (#770)

Source-Link: googleapis/googleapis@c2016e5

Source-Link: googleapis/googleapis-gen@0885fd7
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMDg4NWZkN2FlOGE4MDVhMzc3OTc0ZWRmYmE2MGFiN2M5MzI3Zjc1YSJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api: storage Issues related to the Cloud Storage API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dhermes @coveralls @tseaver @googlebot