Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BigQuery: ensure that KeyboardInterrupt during to_dataframeno longer hangs. #7698

Merged
merged 2 commits into from
Apr 22, 2019
Merged

BigQuery: ensure that KeyboardInterrupt during to_dataframeno longer hangs. #7698

merged 2 commits into from
Apr 22, 2019

Commits on Apr 19, 2019

  1. fix: KeyboardInterrupt during to_dataframe (with BQ Storage API) … 

    …no longer hangs

I noticed in manually testing `to_dataframe` that it would stop
the current cell when I hit Ctrl-C, but data kept on downloading in the
background. Trying to exit the Python shell, I'd notice that it would
hang until I pressed Ctrl-C a few more times.

Rather than get the DataFrame for each stream in one big chunk, loop
through each block and exit if the function needs to quit early. This
follows the pattern at https://stackoverflow.com/a/29237343/101923

Update tests to ensure multiple progress interval loops.
    @tswast
    tswast committed Apr 19, 2019
    Configuration menu
    Copy the full SHA
    da0982d View commit details
    Browse the repository at this point in the history

  2. Refactor _to_dataframe_bqstorage_stream

    @tswast
    tswast committed Apr 19, 2019
    Configuration menu
    Copy the full SHA
    bf73284 View commit details
    Browse the repository at this point in the history