Skip to content

Conversation

@dhermes
Copy link
Contributor

@dhermes dhermes commented Mar 25, 2015

This is an alternative fix to #728, by way of making connection be optional.

This has an effect of cascading through everything since ACL and Blob both use the connection of the Bucket.

Note especially the changes to get_bucket and create_bucket, which passes None through to the Bucket() constructor and lets the environment dictate the connection (e.g. in a batch).


@tseaver Do you think bucket.connection being a non-deterministic value will be confounding?

@dhermes dhermes added the api: storage Issues related to the Cloud Storage API. label Mar 25, 2015
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 25, 2015
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 69c321f on dhermes:bucket-connection-fallback into d34a15e on GoogleCloudPlatform:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 69c321f on dhermes:bucket-connection-fallback into d34a15e on GoogleCloudPlatform:master.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

@dhermes dhermes force-pushed the bucket-connection-fallback branch from 69c321f to f19effa Compare March 28, 2015 18:12
@dhermes dhermes force-pushed the bucket-connection-fallback branch from f19effa to adc470b Compare March 28, 2015 18:13
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling adc470b on dhermes:bucket-connection-fallback into 4d69bb3 on GoogleCloudPlatform:master.

@dhermes
Copy link
Contributor Author

dhermes commented Mar 28, 2015

@tseaver I rebased this after merging #760 but as mentioned, it may make more sense to just pass connection to methods that require it, as in #728 (or use the implicit fallback).

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling adc470b on dhermes:bucket-connection-fallback into 4d69bb3 on GoogleCloudPlatform:master.

@dhermes
Copy link
Contributor Author

dhermes commented Mar 30, 2015

After discussing with @tseaver it has been determined that unbundling Connection and Bucket is possible, so I am closing this out. Will salvage some parts of it, like Bucket.create() and send out another PR.

@dhermes dhermes closed this Mar 30, 2015
@dhermes dhermes deleted the bucket-connection-fallback branch March 30, 2015 20:45
parthea pushed a commit that referenced this pull request Aug 21, 2025
* chore(python): add requirements for docs build

Source-Link: googleapis/synthtool@85c23b6
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:3741fd1f5f5150378563c76afa06bcc12777b5fe54c5ee01115218f83872134f

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Lingqing Gan <lingqing.gan@gmail.com>
parthea pushed a commit that referenced this pull request Sep 16, 2025
* chore(python): add requirements for docs build

Source-Link: googleapis/synthtool@85c23b6
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:3741fd1f5f5150378563c76afa06bcc12777b5fe54c5ee01115218f83872134f

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Lingqing Gan <lingqing.gan@gmail.com>
parthea pushed a commit that referenced this pull request Nov 24, 2025
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea added a commit that referenced this pull request Nov 24, 2025
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea added a commit that referenced this pull request Nov 25, 2025
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea pushed a commit that referenced this pull request Nov 26, 2025
Drop explicit pin / constraint on 'urllib3':  specific 'requests'
versions have very narrow pins, and ours is only likely to create
conflicts.

Bump the 'requests' lower bound to '2.20.0', the lowest version for
which our tests pass once constraints are being checked.

Closes #759
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storage Issues related to the Cloud Storage API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants