Skip to content

Release dns 0.29.2#6946

Merged
crwilcox merged 2 commits intomasterfrom
release-dns-0.29.2
Dec 18, 2018
Merged

Release dns 0.29.2#6946
crwilcox merged 2 commits intomasterfrom
release-dns-0.29.2

Conversation

@crwilcox
Copy link
Contributor

@crwilcox crwilcox commented Dec 18, 2018

This pull request was generated using releasetool.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 18, 2018
tseaver
tseaver suggested changes Dec 18, 2018
View reviewed changes
@tseaver @crwilcox
Update dns/CHANGELOG.md
fa56fc3 
Co-Authored-By: crwilcox <crwilcox@google.com>
@googlebot
Copy link

googlebot commented Dec 18, 2018

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

@googlebot googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Dec 18, 2018
@crwilcox crwilcox added the cla: yes This human has signed the Contributor License Agreement. label Dec 18, 2018
@googlebot
Copy link

googlebot commented Dec 18, 2018

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

@googlebot googlebot removed the cla: no This human has *not* signed the Contributor License Agreement. label Dec 18, 2018
@crwilcox crwilcox merged commit 75fdf92 into master Dec 18, 2018
@yoshi-automation
Copy link
Contributor

yoshi-automation commented Dec 18, 2018

Release is at https://github.com/googleapis/google-cloud-python/releases/tag/dns-0.29.2

@yoshi-automation
Copy link
Contributor

yoshi-automation commented Dec 18, 2018

The release build has started, the log can be viewed here. 🌻

@yoshi-automation
Copy link
Contributor

yoshi-automation commented Dec 18, 2018

The release build failed! Please investigate!

@crwilcox crwilcox deleted the release-dns-0.29.2 branch December 19, 2018 17:05
parthea pushed a commit that referenced this pull request Nov 24, 2025
@crwilcox
Release dns 0.29.2 (#6946)
7381b4d 
* Release 0.29.2

* Update dns/CHANGELOG.md

Co-Authored-By: crwilcox <crwilcox@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@tseaver tseaver tseaver approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autorelease: failed cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@crwilcox @googlebot @yoshi-automation @tseaver