Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Firestore: make cursor-related 'Query' methods accept lists #6697

Merged
merged 4 commits into from
Nov 29, 2018
Merged

Firestore: make cursor-related 'Query' methods accept lists #6697

merged 4 commits into from
Nov 29, 2018

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Nov 29, 2018

Closes #6664.

@tseaver tseaver added the api: firestore Issues related to the Firestore API. label Nov 29, 2018
@tseaver tseaver requested a review from crwilcox as a code owner November 29, 2018 20:29
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 29, 2018
This was referenced Nov 29, 2018
Closed
Merged
crwilcox
crwilcox approved these changes Nov 29, 2018
View reviewed changes
firestore/google/cloud/firestore_v1beta1/query.py
data = document_fields
for order_key in order_keys:
try:
values.append(_helpers.get_nested_value(order_key, data))

This comment was marked as spam.

Sign in to view

@tseaver tseaver merged commit a355ea1 into googleapis:master Nov 29, 2018
@tseaver tseaver deleted the 6664-firestore-cursor_methods_accept_list branch November 29, 2018 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crwilcox crwilcox crwilcox approved these changes

Assignees
No one assigned
Labels
api: firestore Issues related to the Firestore API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tseaver @crwilcox @googlebot