Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bigtable: remove 'deepcopy' from 'PartialRowData.cells' property. #6648

Merged
merged 1 commit into from
Nov 26, 2018
Merged

Bigtable: remove 'deepcopy' from 'PartialRowData.cells' property. #6648

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bigtable/google/cloud/bigtable/row_data.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@ def cells(self):
and second for column names/qualifiers within a family). For
a given column, a list of :class:`Cell` objects is stored.
"""
return copy.deepcopy(self._cells)
return self._cells

@property
def row_key(self):
Expand Down
2 changes: 0 additions & 2 deletions bigtable/tests/unit/test_row_data.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,8 +305,6 @@ def test_cells_property(self):
partial_row_data = self._make_one(None)
cells = {1: 2}
partial_row_data._cells = cells
# Make sure we get a copy, not the original.
self.assertIsNot(partial_row_data.cells, cells)
self.assertEqual(partial_row_data.cells, cells)

def test_row_key_getter(self):
Expand Down