-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Datastore: bump minimum 'api_core' version to 1.4.1. #6391
Datastore: bump minimum 'api_core' version to 1.4.1. #6391
Conversation
Unrelated translation systest failure: see #6427, |
- Bump minimum 'google-api_core' version for all GAPIC libs to 1.4.1. - Lower bounds before upper bounds. - Whitespace for legibility. - Sort them topologically / consistently.
@theacodes Rebased to pick up the translation systest fix merged in #6247. PTAL. |
why are we bumping this for all packages? historically, we've only bumped the version on the package that needed it. |
@theacodes see #6128, #6390. We don't test against older versions, so we don't know when they break until a user tries it (usually via upgrading only $ git grep -l "file=DESCRIPTOR"
asset/google/cloud/asset_v1beta1/proto/asset_service_pb2.py
asset/google/cloud/asset_v1beta1/proto/assets_pb2.py
automl/google/cloud/automl_v1beta1/proto/annotation_payload_pb2.py
automl/google/cloud/automl_v1beta1/proto/classification_pb2.py
automl/google/cloud/automl_v1beta1/proto/data_items_pb2.py
automl/google/cloud/automl_v1beta1/proto/dataset_pb2.py
automl/google/cloud/automl_v1beta1/proto/image_pb2.py
automl/google/cloud/automl_v1beta1/proto/io_pb2.py
automl/google/cloud/automl_v1beta1/proto/model_evaluation_pb2.py
automl/google/cloud/automl_v1beta1/proto/model_pb2.py
automl/google/cloud/automl_v1beta1/proto/operations_pb2.py
automl/google/cloud/automl_v1beta1/proto/prediction_service_pb2.py
automl/google/cloud/automl_v1beta1/proto/service_pb2.py
automl/google/cloud/automl_v1beta1/proto/text_pb2.py
...
vision/google/cloud/vision_v1p3beta1/proto/text_annotation_pb2.py
vision/google/cloud/vision_v1p3beta1/proto/web_detection_pb2.py
websecurityscanner/google/cloud/websecurityscanner_v1alpha/proto/crawled_url_pb2.py
websecurityscanner/google/cloud/websecurityscanner_v1alpha/proto/finding_addon_pb2.py
websecurityscanner/google/cloud/websecurityscanner_v1alpha/proto/finding_pb2.py
websecurityscanner/google/cloud/websecurityscanner_v1alpha/proto/finding_type_stats_pb2.py
websecurityscanner/google/cloud/websecurityscanner_v1alpha/proto/scan_config_pb2.py
websecurityscanner/google/cloud/websecurityscanner_v1alpha/proto/scan_run_pb2.py
websecurityscanner/google/cloud/websecurityscanner_v1alpha/proto/web_security_scanner_pb2.py
$ git grep -l "file=DESCRIPTOR" | cut -d "/" -f 1 | sort -u
asset
automl
bigquery_datatransfer
bigtable
container
dataproc
datastore
dlp
error_reporting
firestore
iot
kms
language
logging
monitoring
oslogin
pubsub
redis
securitycenter
spanner
speech
tasks
texttospeech
trace
videointelligence
vision
websecurityscanner Those libs can only guarantee |
Unrelated flaky storage system test: see #6443. |
Closes #6390.