Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed #634 - Formatting on admonitions looked off. #635

Merged
merged 1 commit into from
Feb 13, 2015
Merged

Fixed #634 - Formatting on admonitions looked off. #635

merged 1 commit into from
Feb 13, 2015

Conversation

jgeewax
Copy link
Contributor

@jgeewax jgeewax commented Feb 13, 2015

Before:
note-before

After:
note-after

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 13, 2015
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling b78d161 on jgeewax:634-admonition-formatting into f73ad7e on GoogleCloudPlatform:master.

@dhermes
Copy link
Contributor

dhermes commented Feb 13, 2015

LGTM

@dhermes
Copy link
Contributor

dhermes commented Feb 13, 2015

@jgeewax I'm going to merge this for you. Typically @tseaver and I merge our own PRs in case we need to handle rebases or other, but I'm not sure what your expectation is.

dhermes added a commit that referenced this pull request Feb 13, 2015
@dhermes
Merge pull request #635 from jgeewax/634-admonition-formatting
7c5ffd9 
Fixed #634 - Formatting on admonitions looked off.
@dhermes dhermes merged commit 7c5ffd9 into googleapis:master Feb 13, 2015
@jgeewax
Copy link
Contributor Author

jgeewax commented Feb 13, 2015 via email

@dhermes dhermes mentioned this pull request Feb 14, 2015
Merged
vchudnov-g pushed a commit that referenced this pull request Sep 20, 2023
@release-please
chore(main): release 2.22.0 (#635)
7c5bbbd 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jgeewax @coveralls @dhermes @googlebot