-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BigQuery: use _get_sub_prop helper so missing load stats don't raise. #6269
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
8a34642
to
1eceb60
Compare
CLAs look good, thanks! |
return int(statistics['load']['inputFileBytes']) | ||
return _helpers._get_sub_prop( | ||
self._properties, ['statistics', 'load', 'inputFileBytes'] | ||
) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
return int(statistics['load']['inputFiles']) | ||
return _helpers._get_sub_prop( | ||
self._properties, ['statistics', 'load', 'inputFiles'] | ||
) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
return int(statistics['load']['outputBytes']) | ||
return _helpers._get_sub_prop( | ||
self._properties, ['statistics', 'load', 'outputBytes'] | ||
) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
return int(statistics['load']['outputRows']) | ||
return _helpers._get_sub_prop( | ||
self._properties, ['statistics', 'load', 'outputRows'] | ||
) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
@dpebot merge when green, please. |
Okay! I'll merge when all statuses are green and all reviewers approve. |
@theacodes I have no idea why @dpebot drops the ball on this one. |
@hrfuller Thanks for the patch! |
No description provided.