Fix #533: add key and entity equality methods #615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move '_dataset_ids_equal' from 'helpers' -> 'key', because it is only useful for keys, and we don't want the cycle.
Closes #533.
googlebot
added
the
cla: yes
tseaver
changed the title
|
Note that this PR assumes my "incomplete keys never compare equal" simplification. |
|
I like the simplification. Reviewing now. |
| :returns: True if the entities compare equal, else False. | ||
| """ | ||
| if not isinstance(other, Entity): | ||
| raise NotImplementedError |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
Overall looks good, pending my comments. |
tseaver
added a commit
that referenced
this pull request
Feb 12, 2015
Fix #533: add key and entity equality methods
dhermes
added a commit
to dhermes/google-cloud-python
that referenced
this pull request
Feb 12, 2015
Utilizing changes in googleapis#615.
This was referenced Feb 12, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
Key.{__eq__,__ne__,__hash__}, including correct handling of prefixed dataset IDs.Move
helpers._dataset_ids_equal->key, for better separation of concerns (and to avoid a cycle).Add
Entity.{__eq__,__ne__}.Fixes #533