-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Test runs for Python 3.7 and remove 3.4 #5295
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice
Are you sure about the 3.4 bit? It is still the default |
@tseaver: @jonparrott looked up the stats and said ~4%. We can leave it if you have strong feelings about it. It seemed a convenient time to not elongate the test runs is all. |
Let me double check that... I am bad at math.
…On Thu, May 3, 2018, 1:47 PM Christopher Wilcox ***@***.***> wrote:
@tartavull <https://github.com/tartavull> @jonparrott
<https://github.com/jonparrott> looked up the stats and said ~4%. We can
leave it if you have strong feelings about it. It seemed a convenient time
to not elongate the test runs is all.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#5295 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAPUc1R6tt34CdAELzv52RBmSz11o7oUks5tu2zIgaJpZM4TxuS7>
.
|
Okay, looking over the last 6 months of download stats from BigQuery:
Our packages have been installed a total of 54,568,855 times with 785,977 of those downloads originating from a Python 3.4 version. That means that Python 3.4 accounts for just 1.44% of our install base. By comparison, 3.4 accounts for 3.58% of the overall installs for all packages over the last 6 months. Summoning @tswast to make sure I didn't do something stupid here. |
Query looks right, though I'd filter out the "bandersnatch" installs with P.S. I could give you some help updating to standard SQL syntax if you'd like. |
Thanks @tswast. Limiting to just pip installs made the Py 3.4 percentage even lower at 1.43%. ;) |
…Queue and Queue
* remove 3.4 from unit test runs * add 3.7 to most packages. PubSub, Monitoring, BigQuery not enabled * Fix #5292 by draining queue in a way compatible with SimpleQueue and Queue
* remove 3.4 from unit test runs * add 3.7 to most packages. PubSub, Monitoring, BigQuery not enabled * Fix #5292 by draining queue in a way compatible with SimpleQueue and Queue
* remove 3.4 from unit test runs * add 3.7 to most packages. PubSub, Monitoring, BigQuery not enabled * Fix #5292 by draining queue in a way compatible with SimpleQueue and Queue
* remove 3.4 from unit test runs * add 3.7 to most packages. PubSub, Monitoring, BigQuery not enabled * Fix #5292 by draining queue in a way compatible with SimpleQueue and Queue
* remove 3.4 from unit test runs * add 3.7 to most packages. PubSub, Monitoring, BigQuery not enabled * Fix #5292 by draining queue in a way compatible with SimpleQueue and Queue
* remove 3.4 from unit test runs * add 3.7 to most packages. PubSub, Monitoring, BigQuery not enabled * Fix #5292 by draining queue in a way compatible with SimpleQueue and Queue
* remove 3.4 from unit test runs * add 3.7 to most packages. PubSub, Monitoring, BigQuery not enabled * Fix #5292 by draining queue in a way compatible with SimpleQueue and Queue
* remove 3.4 from unit test runs * add 3.7 to most packages. PubSub, Monitoring, BigQuery not enabled * Fix #5292 by draining queue in a way compatible with SimpleQueue and Queue
* remove 3.4 from unit test runs * add 3.7 to most packages. PubSub, Monitoring, BigQuery not enabled * Fix #5292 by draining queue in a way compatible with SimpleQueue and Queue
* remove 3.4 from unit test runs * add 3.7 to most packages. PubSub, Monitoring, BigQuery not enabled * Fix #5292 by draining queue in a way compatible with SimpleQueue and Queue
* remove 3.4 from unit test runs * add 3.7 to most packages. PubSub, Monitoring, BigQuery not enabled * Fix #5292 by draining queue in a way compatible with SimpleQueue and Queue
* remove 3.4 from unit test runs * add 3.7 to most packages. PubSub, Monitoring, BigQuery not enabled * Fix #5292 by draining queue in a way compatible with SimpleQueue and Queue
* remove 3.4 from unit test runs * add 3.7 to most packages. PubSub, Monitoring, BigQuery not enabled * Fix #5292 by draining queue in a way compatible with SimpleQueue and Queue
* remove 3.4 from unit test runs * add 3.7 to most packages. PubSub, Monitoring, BigQuery not enabled * Fix #5292 by draining queue in a way compatible with SimpleQueue and Queue
* remove 3.4 from unit test runs * add 3.7 to most packages. PubSub, Monitoring, BigQuery not enabled * Fix #5292 by draining queue in a way compatible with SimpleQueue and Queue
* remove 3.4 from unit test runs * add 3.7 to most packages. PubSub, Monitoring, BigQuery not enabled * Fix #5292 by draining queue in a way compatible with SimpleQueue and Queue
* remove 3.4 from unit test runs * add 3.7 to most packages. PubSub, Monitoring, BigQuery not enabled * Fix #5292 by draining queue in a way compatible with SimpleQueue and Queue
There are very few people using 3.4 and 3.7 is coming up. A few of the packages cannot use 3.7 yet
PubSub: #5292
Monitoring: #5293
BigQuery: #5294