BigTable: Add split keys on create table#5283
Closed
aneepct wants to merge 92 commits intogoogleapis:masterfrom
Closed
BigTable: Add split keys on create table#5283aneepct wants to merge 92 commits intogoogleapis:masterfrom
aneepct wants to merge 92 commits intogoogleapis:masterfrom
Conversation
…into feature/read_rows_retry
googlebot
added
the
cla: yes
Contributor
|
This also seems to need to be rebased. |
Contributor
|
Why are there app_profile changes here? Can you please remove them? |
Contributor
|
Also, please rebase on master. There are 90 commits here, and I doubt they are related to your change. |
sduskis
suggested changes
May 22, 2018
Contributor
sduskis
left a comment
sduskis
left a comment
There was a problem hiding this comment.
Can you please add a system test for this new functionality?
Contributor
|
Can you please rebase this PR? |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add ability to create initial splits during creation of a table. This feature branch is a fork from the GAPIC integration branch (PR #5178).