BigTable: Add data app profile id by aneepct · Pull Request #5275 · googleapis/google-cloud-python

aneepct · 2018-05-01T04:59:50Z

Add ability to specify the app_profile_id to use for the following Table methods:

read_rows
mutate_rows
sample_row_keys

…thub.com/zakons/google-cloud-python into feature/gapic

…into feature/read_rows_retry

zakons · 2018-05-01T05:07:39Z

@jonparrott @sduskis This PR is created on a fork of the GAPIC branch (PR #5178). After that PR is merged with master, we can rebase it if you prefer. Either way, please review.

Note that this is one of a series of PR's that we will create to add methods to the current Instance and Table classes to provide access to the user of the underlying, transparent GAPIC clients, specifically for management functions. All of these PR's are similarly forks of the GAPIC branch. If you have any preferences on how you want this managed, please comment. The purpose of doing multiple smaller PR's is to move these out more quickly.

sduskis · 2018-05-03T15:31:10Z

@aneepct, can you please rebase this change on mast now that #5178 was merged?

sduskis · 2018-05-03T15:49:08Z

@zakons, how difficult would it be to rebase to master? It's very hard to review this PR as is

sduskis

create_app_profile does not work as is. The only parameter is the id of the profile, but the actual profile is not passed in. @zakons, can we please review this?

bigtable/google/cloud/bigtable/instance.py


        return result
+
+    def create_app_profile(self, app_profile_id):


bigtable/google/cloud/bigtable/instance.py

+            self._client._instance_admin_client.list_app_profiles(self.name))
+        return list_app_profiles
+
+    def update_app_profile(self, app_profile_id, ignore_warnings=None):


bigtable/google/cloud/bigtable/table.py

    """

-    def __init__(self, table_id, instance):
+    def __init__(self, table_id, instance, app_profile_id=None):


aneepct · 2018-05-09T09:58:35Z

Split app_profile_id PR into 2 separate PR's:

#5275 use app_profile_id in data methods:

read_rows
mutate_rows
sample_row_keys

#5315 use app_profile in admin methods:

create_app_profile
get_app_profile
list_app_profiles
update_app_profile
delete_app_profile

bigtable/google/cloud/bigtable/table.py

+            self.name, app_profile_id=self._app_profile_id)
        return response_iterator

+    def truncate(self, timeout=60):


aneepct · 2018-05-22T11:45:00Z

@sduskis Separated truncate and drop by prefix to new #5360 PR

sduskis · 2018-05-22T12:53:22Z

Can you please rebase this PR?

Also, please remove " on top of GAPIC integration" from the title.

sduskis

row.py needs to be updated as well. It has some data calls that require app_profile_id

aneepct · 2018-05-23T11:12:53Z

@sduskis I created new PR #5369 to prevent few merge conflicts going to close this PR

Luke Sneeringer and others added 30 commits January 4, 2018 10:29

Provide new auto-generated layer for Bigtable.

3edca4c

Merge branch 'master' into bigtable-regen

a677959

Add retry for read rows

d540349

Fix line lengths

4aa5702

Add parameter start_inclusive to _create_row_request

f7d4c69

Update unit test case for yield rows retry

28892ce

Fix line lengths

8d141f0

Edit table.py as requested changes

902f11b

Added code review changes from @jonparrott.

4afabb1

Fix parameter name on _RetryableReadRows class

79698b1

Add retry for Deadline Exceeded on read rows

9b778be

Fix line over-indented

cafc5ad

Fix line over-indented

f974752

Merge commit '3edca4c3299e85d4346dae49232d540a2d34002c' of https://gi…

f7242f4

…thub.com/zakons/google-cloud-python into feature/gapic

Merge commit 'a67795951bc9f490265eda7cf511e17d2cc70921' of https://gi…

180d1d5

…thub.com/zakons/google-cloud-python into feature/gapic

Working on gapic integration

f2e39e0

Refactore yield_rows retry

13adfd6

1. Moved last_scanned_row_key into YieldRowsData.

ca69a2f

Fix line over-indented

02c154e

Fix row_data.py

b6da7fa

Change row.py as requested

f1a2d92

Create new test case for yield_rows iterator failure

65c1c4b

Fix for start_inclusive on retry read rows.

170a173

Merge branch 'master' of https://github.com/zakons/google-cloud-python …

5da3fd3

…into feature/read_rows_retry

Change bigtable_pb2 imports to use from gapic library.

f7a58b5

Merge branch 'feature/read_rows_retry' of https://github.com/zakons/g…

c8f664b

…oogle-cloud-python into feature/gapic

Working on gapic

d5f0d98

Integrate bigtable GAPIC client

32df7bd

Refactoring unit tests

77ec950

Refactor to use GAPIC client

efbf2f5

aneepct requested a review from tseaver as a code owner May 1, 2018 04:59

googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 1, 2018

aneepct added 2 commits May 2, 2018 09:45

add drop_key_range

bf0176a

Add timeout on truncate and drop_by_prefix

284d723

aneepct changed the title ~~BigTable: Add app profile id on top of GAPIC integration~~ BigTable: Add app profile id on top of GAPIC integration and truncate table May 2, 2018

aneepct changed the title ~~BigTable: Add app profile id on top of GAPIC integration and truncate table~~ BigTable: Add app profile id and truncate table on top of GAPIC integration May 2, 2018

Fix too many blank lines

015ce18

zakons mentioned this pull request May 3, 2018

BigTable: Integration of GAPIC #5178

Merged

tseaver added the api: bigtable Issues related to the Bigtable API. label May 3, 2018

Rebase with master

db9405e

theacodes approved these changes May 3, 2018

View reviewed changes

sduskis suggested changes May 7, 2018

View reviewed changes

aneepct added 4 commits May 8, 2018 17:03

Add app_profile create and update parameter

7522bbd

Fix branch coverage for update app profile

9cdf4ad

Remove admin app profile methods

0abc775

Remove unused imports

6808aea

zakons mentioned this pull request May 10, 2018

BigTable: Modify system test for new GAPIC code #5302

Merged

sduskis reviewed May 18, 2018

View reviewed changes

bigtable/google/cloud/bigtable/table.py Outdated

self.name, app_profile_id=self._app_profile_id)

return response_iterator

def truncate(self, timeout=60):

This comment was marked as spam.

Sign in to view

Rebase with master and remove truncate and drop_by_prefix from this PR

ef64863

aneepct changed the title ~~BigTable: Add app profile id and truncate table on top of GAPIC integration~~ BigTable: Add data app profile id on top of GAPIC integration May 22, 2018

sduskis suggested changes May 22, 2018

View reviewed changes

aneepct changed the title ~~BigTable: Add data app profile id on top of GAPIC integration~~ BigTable: Add data app profile id May 23, 2018

aneepct closed this May 23, 2018

Conversation

aneepct commented May 1, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

zakons commented May 1, 2018

Uh oh!

sduskis commented May 3, 2018

Uh oh!

sduskis commented May 3, 2018

Uh oh!

sduskis left a comment

Choose a reason for hiding this comment

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

aneepct commented May 9, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as spam.

Uh oh!

aneepct commented May 22, 2018

Uh oh!

sduskis commented May 22, 2018

Uh oh!

sduskis left a comment

Choose a reason for hiding this comment

Uh oh!

aneepct commented May 23, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

aneepct commented May 1, 2018 •

edited

Loading

aneepct commented May 9, 2018 •

edited

Loading