Spanner: system tests use database instead of session #4744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
chemelnucfin
force-pushed
the
spanner_tests_session_removal
branch
from
08835aa
to
16fae92
Compare
chemelnucfin
changed the title
chemelnucfin
force-pushed
the
spanner_tests_session_removal
branch
from
16fae92
to
c9fcb2d
Compare
theacodes
reviewed
Jan 12, 2018
spanner/tests/system/test_system.py
Outdated
| rows = list(results_iter) | ||
| self.assertEqual(rows, [expected[row]]) | ||
| with self._db.snapshot() as snapshot: | ||
| results_iter = snapshot.read(self.TABLE, |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
theacodes
approved these changes
Jan 12, 2018
chemelnucfin
force-pushed
the
spanner_tests_session_removal
branch
from
c9fcb2d
to
0b90f98
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are still a couple of them that use session, I'll look later on them.