nox unittest updates by chemelnucfin · Pull Request #4646 · googleapis/google-cloud-python

chemelnucfin · 2017-12-20T23:59:10Z

Manually changed. Where do I change the generator?
@dhermes @lukesneeringer

bigquery_datatransfer/nox.py

 @nox.session
-@nox.parametrize('python_version', ['2.7', '3.4', '3.5', '3.6'])
-def unit_tests(session, python_version):
+def default(session):


bigquery_datatransfer/nox.py

+    This is intended to be run **without** an interpreter set, so
+    that the current ``python`` (on the ``PATH``) or the version of
+    Python corresponding to the ``nox`` binary the ``PATH`` can
+    run the tests.


bigquery_datatransfer/nox.py

+
+
+@nox.session
+def cover(session):


bigquery_datatransfer/nox.py


+LOCAL_DEPS = (
+    os.path.join('..', 'api_core'),
+    os.path.join('..', 'core'),


container/nox.py


+LOCAL_DEPS = (
+    os.path.join('..', 'api_core'),
+    os.path.join('..', 'core'),


dataproc/nox.py


+LOCAL_DEPS = (
+    os.path.join('..', 'api_core'),
+    os.path.join('..', 'core'),


bigquery_datatransfer/nox.py

+    session.install('coverage', 'pytest-cov')
+    session.run('coverage', 'report', '--show-missing', '--fail-under=70')
+    # uncomment when coverage is met
+    # session.run('coverage', 'report', '--show-missing', '--fail-under=100')    


dhermes

LGTM

container/nox.py

+
+    This is intended to be run **without** an interpreter set, so
+    that the current ``python`` (on the ``PATH``) or the version of
+    Python corresponding to the ``nox`` binary the ``PATH`` can


chemelnucfin requested a review from lukesneeringer as a code owner December 20, 2017 23:59

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 20, 2017

dhermes reviewed Dec 21, 2017

View reviewed changes

bigquery_datatransfer/nox.py

@nox.session

@nox.parametrize('python_version', ['2.7', '3.4', '3.5', '3.6'])

def unit_tests(session, python_version):

def default(session):

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

chemelnucfin force-pushed the nox branch 7 times, most recently from b0d4747 to f2c9bcc Compare December 21, 2017 05:39

dhermes reviewed Dec 21, 2017

View reviewed changes

chemelnucfin mentioned this pull request Dec 27, 2017

Inconsistent nox session names #4645

Closed

dhermes approved these changes Jan 2, 2018

View reviewed changes

container/nox.py Outdated

This is intended to be run **without** an interpreter set, so

that the current ``python`` (on the ``PATH``) or the version of

Python corresponding to the ``nox`` binary the ``PATH`` can

This comment was marked as spam.

Sign in to view

nox unittest updates

79b0629

chemelnucfin force-pushed the nox branch from c2cb898 to 79b0629 Compare January 3, 2018 05:41

chemelnucfin merged commit e58fecd into googleapis:master Jan 3, 2018

chemelnucfin deleted the nox branch January 3, 2018 06:04

parthea pushed a commit that referenced this pull request Sep 22, 2023

nox unittest updates (#4646)

eca19c6

parthea pushed a commit that referenced this pull request Sep 22, 2023

nox unittest updates (#4646)

d33c8a9

parthea pushed a commit that referenced this pull request Sep 22, 2023

nox unittest updates (#4646)

137d7ee

Conversation

chemelnucfin commented Dec 20, 2017

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

dhermes left a comment

Choose a reason for hiding this comment

Uh oh!

This comment was marked as spam.

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants